From cbc246e914b9c3b17656856fedaf621a53005ede Mon Sep 17 00:00:00 2001
From: Mark Tripod <mtripod@duosecurity.com>
Date: Fri, 8 Nov 2024 14:24:17 -0500
Subject: [PATCH 1/2] chore: update_integration() function parameter
 clarification

add policy_key parameter
add deprecation warning for visual_style parameter

Tested-by: manual testing
---
 duo_client/admin.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/duo_client/admin.py b/duo_client/admin.py
index 95c1d40..597762e 100644
--- a/duo_client/admin.py
+++ b/duo_client/admin.py
@@ -2792,7 +2792,7 @@ def update_integration(self,
                            trusted_device_days=None,
                            ip_whitelist=None,
                            ip_whitelist_enroll_policy=None,
-                           groups_allowed=None,
+                           groups_allowed=None, policy_key=None,
                            self_service_allowed=None,
                            sso=None):
         """Updates an integration.
@@ -2800,7 +2800,7 @@ def update_integration(self,
         integration_key - The key of the integration to update. (required)
         name - The name of the integration (optional)
         visual_style - (optional, default 'default')
-                       See adminapi docs for possible values.
+                       Deprecated. May be removed in a future release.
         greeting - Voice greeting (optional, default '')
         notes - internal use (optional, uses default setting)
         enroll_policy - <'enroll'|'allow'|'deny'> (optional, default 'enroll')
@@ -2818,6 +2818,8 @@ def update_integration(self,
         adminapi_write_resource - True|False|None
         reset_secret_key - <any value>|None
         groups_allowed - <str: CSV list of gkeys of groups allowed to auth>
+        policy_key - <str: policy key of custom application policy>|None
+                    An empty string results in removal of any existing policy key setting.
         self_service_allowed - True|False|None
         sso - <dict: parameters for generic single sign-on> (optional)
                 New argument for unreleased feature. Will return an error if used.
@@ -2838,6 +2840,8 @@ def update_integration(self,
         if name is not None:
             params['name'] = name
         if visual_style is not None:
+            warnings.warn("The 'visual_style' argument is deprecated. May be removed in a future release.",
+                          DeprecationWarning, stacklevel=2)
             params['visual_style'] = visual_style
         if greeting is not None:
             params['greeting'] = greeting
@@ -2873,6 +2877,8 @@ def update_integration(self,
             params['reset_secret_key'] = '1'
         if groups_allowed is not None:
             params['groups_allowed'] = groups_allowed
+        if policy_key is not None:
+            params['policy_key'] = policy_key
         if self_service_allowed is not None:
             params['self_service_allowed'] = '1' if self_service_allowed else '0'
         if sso is not None:

From 9b31d463447242ae5443f0ffb7dbc1b4bd0b892d Mon Sep 17 00:00:00 2001
From: Mark Tripod <66480604+MarkTripod-Duo@users.noreply.github.com>
Date: Fri, 15 Nov 2024 08:14:17 -0500
Subject: [PATCH 2/2] Update update_integration() in admin.py

Updated parameter definition indentation to match previous iteration for consistency.
---
 duo_client/admin.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/duo_client/admin.py b/duo_client/admin.py
index 597762e..bcb332b 100644
--- a/duo_client/admin.py
+++ b/duo_client/admin.py
@@ -2792,7 +2792,8 @@ def update_integration(self,
                            trusted_device_days=None,
                            ip_whitelist=None,
                            ip_whitelist_enroll_policy=None,
-                           groups_allowed=None, policy_key=None,
+                           groups_allowed=None, 
+                           policy_key=None,
                            self_service_allowed=None,
                            sso=None):
         """Updates an integration.