Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter limits disagree with Duo documentation #23

Open
AaronAtDuo opened this issue Feb 2, 2024 · 1 comment
Open

Parameter limits disagree with Duo documentation #23

AaronAtDuo opened this issue Feb 2, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@AaronAtDuo
Copy link
Contributor

Description

The code comments for the state parameter indicate the minimum length of state is 22 characters, but the Duo docs (https://duo.com/docs/oauthapi#authorization-request) indicate it's 16. Let's reconcile the two.

Expected Behavior

Anywhere the parameter limits (state and nonce primarily) are described, they agree with the Duo documentation.

Actual Behavior

The state parameter limits disagree.

Steps to Reproduce

N/A

Workarounds

N/A

@AaronAtDuo AaronAtDuo added the documentation Improvements or additions to documentation label May 10, 2024
@AaronAtDuo AaronAtDuo added the good first issue Good for newcomers label Jul 31, 2024
@gcoxmoz
Copy link
Contributor

gcoxmoz commented Dec 4, 2024

Looks like this was fixed in 0716495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants