Code Improvments: remove enum static, rename fields and methods, create final static #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squid:MissingDeprecatedCheck Deprecated elements should have both the annotation and the Javadoc tag squid:S1845 Methods and field names should not be the same or differ only by capitalization squid:S1170 Public constants and fields initialized at declaration should be static final rather than merely final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule
squid:S2786 Nested enum should not be declared static
squid:MissingDeprecatedCheck Deprecated elements should have both the annotation and the Javadoc tag
squid:S1845 Methods and field names should not be the same or differ only by capitalization
squid:S1170 Public constants and fields initialized at declaration should be static final rather than merely final
You can find more information about the issue here:
https://dev.eclipse.org/sonar/coding_rules#q=squid:S2786
https://dev.eclipse.org/sonar/coding_rules#q=squid:MissingDeprecatedCheck
https://dev.eclipse.org/sonar/coding_rules#q=squid:S1845
https://dev.eclipse.org/sonar/coding_rules#q=squid:S1170
Please let me know if you have any questions.
Zeeshan