style: fix button background color when clicked in HomeBanner and Navbar #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gl-cardillo, the same button is used multiple times throughout the UI, could you please fix them all in the PR? |
|
Hello @dvjsharma , I have fixed the background in all buttons that use focus: |
dvjsharma
approved these changes
Jul 18, 2024
|
Hi @gl-cardillo ,changes looks good. Please rebase with latest master to remove the redundant commits. |
gl-cardillo
force-pushed
the
gl-cardillo/125/button-colour-clicked
branch
2 times, most recently
from
5a120a4
to
769a76e
Compare
|
|
|
I can still see commits form other authors. Please rebase and force push. |
gl-cardillo
force-pushed
the
gl-cardillo/125/button-colour-clicked
branch
from
769a76e
to
c67cb62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Button colour still black once clicked.
Changes
This issue was caused by the :focus pseudo-class. It was applied to change the border and text color but not the background color. To resolve this, I have added the background change to the :focus pseudo-class.
fixes #125