Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist size #1485

Open
wants to merge 2 commits into
base: dev/1.55.0
Choose a base branch
from
Open

Persist size #1485

wants to merge 2 commits into from

Conversation

omgtehlion
Copy link
Contributor

I propose several changes, please let me know if these are too much.

  • use initializer-list to popultate QSet given to OrlojView::hideChildren, this cleans up code a little bit
  • use setVisible() instead of show()/hide(), this function checks current state and is no-op if visibility does not change
  • use QList instead of QSet, to easily iterate over given collection. For small lists performance might be even improved due to denser memory layout and sequential access in contains() method
  • actually save size of left panel, if there were two already. Right panel takes up remaining space

@omgtehlion omgtehlion changed the base branch from master to dev/1.55.0 August 29, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant