Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up code-base #12

Open
dwarry opened this issue Apr 11, 2018 · 0 comments
Open

Tidy up code-base #12

dwarry opened this issue Apr 11, 2018 · 0 comments
Assignees
@dwarry
Labels
techdebt Technical Debt issues that need to be cleaned up
Milestone
v0.2

Comments

@dwarry
Copy link
Owner

dwarry commented Apr 11, 2018

Now that I've got the basic structure working, I need to have a bit of a tidyup and refactor.

  • Does each TreeItem need have its own guard conditions and commands? Probably best dealt with at the top of the hierarchy
@dwarry dwarry added the techdebt Technical Debt issues that need to be cleaned up label Apr 11, 2018
@dwarry dwarry added this to the v0.2 milestone Apr 11, 2018
dwarry added a commit that referenced this issue Apr 17, 2018
@dwarry
Refactored TreeItems to get rid of individual OAPH guard properties; …
3aad957 
…they only need to be acccess when the Selected item is changed, not on the fly.

Also changed MindMapViewModel to use a root element, rather than just a list of first-level children - this will make it easier to Zoom In later...

#12
@dwarry dwarry self-assigned this Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwarry dwarry

Labels
techdebt Technical Debt issues that need to be cleaned up
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
1 participant
@dwarry