Carrierwave Direct changes old uploads path

[shlomizadok]

Hi,
Until recently we have used CarrierWave gem to upload our files.
We have now changed to carrierwave_direct and it works excellently (thanks!), besides one issue:

When we update model's attribute, without changing the file, when saving it adds the store_dir parameter anyhow, so if in my Book model - one book looked like:
{ name => "Hello Carrierwave Direct", key => "books/hello.epub" }
After editing (the name only) it would change to
{ name => "Hello edited name", key => "books/books/hello.epub" }

It adds automatically "books/" (yet it will not add the "books" if I have replaced the file via carrierwave_direct

Any clue?

[nddeluca]

I think this may be related to #101, which is a result of incompatibilities between carrierwave and carrierwave_direct unfortunately. Can you try https://github.com/nddeluca/carrierwave_direct on master and see if that fixed your issue? I have a fix for #101 there and am working towards getting it ready to be merged into carrierwave_direct's master.

[shlomizadok]

I'm afraid it is not related. I have set my gem to run vs. nddeluca/carrierwave_direct and I get the same result. :\

[shlomizadok]

@nddeluca, I think I found a solution on your fork, I have created a pull request (nddeluca#1) -- return old key if the new key equals the old key.
It works for me. Let me know if it doesn't break anything on your side and the logic is good.
(btw, nice refactoring you did there...)

[p8]

This should be fixed on master