Deployment

[samhstn]

We will need to run the seed file on heroku when deploying and simultaneously set up webhooks on all dwyl repos.

All the logic for this has been built and tested as of #201

[samhstn]

Will also need to ensure to clean up webhooks attached to repos and ensure there is space for the new ones

[samhstn]

@nelsonic should we deploy now to be able to use the app or should we wait for #197 (comment) to be addressed (it will still be very useable without this)?

[iteles]

@Shouston3 Yes, let's definitely deploy what we have please 😊
Can't do internal user testing without it!
Can we simultaneously also update the readme to explain the current limitations and refer to the issues?

[samhstn]

Will do 👍

[samhstn]

@Jbarget has made progress with the deployment. Just need to remove the other hooks on the dwyl repos and run the seed file with the new hooks

[samhstn]

@ZooeyMiller @finnhodgkin Steps to deploy the app are roughly as follows:

You'll first need to run some things from the IEx shell (iex -S mix) locally, run something like

alias Tudo.{GithubApi, Hook}
"dwyl" |> GithubApi.get_repos |> Enum.filter(some_filter) |>  Hook.delete(some_url)

Essentially remove all the webhooks that are pointing at a ngrok server and instead add hooks that point to the heroku app instead.
Check out how to do that in this file: https://github.com/dwyl/tudo/blob/master/web/github/hook.ex
and here: https://github.com/dwyl/tudo/blob/master/web/github/github_api.ex#L43
Also when you manage that, could you update the readme with how to do this #213

Let me know how you get on and post any questions here if they pop up

[finnhodgkin]

Thanks Sam, sounds clear enough! We'll have a go now 👍

[samhstn]

From this question:

We tried accessing it using the env variables saved on the heroku app but they're
giving us non-responses from github
({"documentation_url", "https://developer.github.com/v3"}).
Maybe we're doing something else wrong, or the heroku setup is out of date.
Should we just make our own temporary ones (didn't seem to work) or
are there some working env vars with appropriate permissions?

You might need to ensure that your github account has the appropriate access and that your personal access token also has the appropriate access.

Can you provide example requests that you are sending which should be working, but aren't. E.g.

curl https://api.github.com/orgs/dwyl/repos\?page_results\=100\&page\=2 # gives us 404 ?

[finnhodgkin]

Pretty sure the Heroku access_token has been revoked and Zooey and I don't have permissions for dwyl github things.

It works perfectly on my own repos 👍

[samhstn]

I see, you'll need to get 2 factor auth and approved by @iteles or @nelsonic to be allowed to have write access to dwyl repos. I'll share one of my pa keys for now so you can continue.

[samhstn]

It does seem like a permissions issue as for the repositories which I am getting this response

I also don't have a settings tab in the github navbar.

Whereas I have a settings bar for repos which I can access the webhooks for.

One strange thing is that we are getting a 404 error and not 401 unauthorised error

@nelsonic @iteles @markwilliamfirth could one of you try sending the exact same postman request but with your username and personal access token as the password and see if you get a different response (or anyone else with admin access or a settings tab on dwyl/learn-tdd @SimonLab?).

[samhstn]

Nice spot btw @finnhodgkin @ZooeyMiller

[Danwhy]

It looks like webhooks need admin access to repos: https://developer.github.com/v3/orgs/hooks/, and it also looks like the core dwyl team doesn't have admin access to all repos: https://github.com/orgs/dwyl/teams/core/repositories. This would make sense of the problems @finnhodgkin was having (the core team only have write access to learn-tdd and learn-tape, but admin access tolearn-redux).

So to fix this permissions issue we'd need to use an access token from either an owner of the dwyl organisation, or somebody with admin access to all of the repos

[iteles]

Thanks for the summary @Danwhy! Agreed that an owner token probably makes more sense as Nelson and I for example will (hopefully) be a constant and we won't need to keep swapping them around. Let's work to get you what you need (as long as we limit the access to the minimum set and if tudo is hacked they can't go deleting all our repos)!

[iteles]

Done for the following & sent to @Danwhy :

[Danwhy]

I think we'd just need access to repo hooks and org hooks. That shouldn't be a security issue as webhooks just send information to us, and don't allow any write access.

@Shouston3, @finnhodgkin, @ZooeyMiller, @Jbarget Can you confirm those are the only permissions we need?

[samhstn]

@Danwhy I think those permissions will be all we need

[iteles]

Thank you both! (hai @Shouston3 👋 Hope you're well!)

[Danwhy]

All current repos now have the webhook attached to them, and the database should be completely up to date with all of the current issues

[samhstn]

All looking deployed to me, nice @Danwhy 👍

Tested on https://tudo-app.herokuapp.com