From c29878d6976a80c5abfc8586317fb5b2c213bbb8 Mon Sep 17 00:00:00 2001 From: Teddy Ding Date: Wed, 8 Jan 2025 16:24:00 -0500 Subject: [PATCH] fix script syntax --- indexer/packages/postgres/README.md | 2 ++ .../src/scripts/handlers/dydx_perpetual_market_v2_handler.sql | 4 ++-- .../src/scripts/handlers/dydx_update_perpetual_v2_handler.sql | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/indexer/packages/postgres/README.md b/indexer/packages/postgres/README.md index c4ddb219014..a8febac17f9 100644 --- a/indexer/packages/postgres/README.md +++ b/indexer/packages/postgres/README.md @@ -7,6 +7,8 @@ Add a knex migration by running `pnpm run migrate:make ` Run the migration with `pnpm run migrate` +In `__tests__/db/migrations.test.ts`, test cases may be expected to fail (and hence should be commented out) if a model is modified due to the latest migration. + In order to migrate in dev and staging, you must redeploy and run bazooka. TODO(CORE-512): Add info/resources around bazooka. [Doc](https://www.notion.so/dydx/Engineering-Runbook-15064661da9643188ce33e341b68e7bb#cb2283d80ef14a51924f3bd1a538fd82). diff --git a/indexer/services/ender/src/scripts/handlers/dydx_perpetual_market_v2_handler.sql b/indexer/services/ender/src/scripts/handlers/dydx_perpetual_market_v2_handler.sql index 44945aa2836..e0c0c9c2961 100644 --- a/indexer/services/ender/src/scripts/handlers/dydx_perpetual_market_v2_handler.sql +++ b/indexer/services/ender/src/scripts/handlers/dydx_perpetual_market_v2_handler.sql @@ -34,10 +34,10 @@ BEGIN /* For backwards compatibility, handle the case where defaultFundingPpm is not present */ CASE /* Convert defaultFundingPpm from parts-per-million to a rate */ - WHEN event_data ? 'defaultFunding8hrPpm' THEN dydx_trim_scale( + WHEN (event_data->>'defaultFunding8hrPpm') IS NOT NULL THEN dydx_trim_scale( power(10, PPM_EXPONENT) / FUNDING_RATE_FROM_PROTOCOL_IN_HOURS * - (event_data->'defaultFunding8hrPpm')::numeric); + (event_data->'defaultFunding8hrPpm')::numeric) ELSE 0.0 END; diff --git a/indexer/services/ender/src/scripts/handlers/dydx_update_perpetual_v2_handler.sql b/indexer/services/ender/src/scripts/handlers/dydx_update_perpetual_v2_handler.sql index 1e49733b9e6..df54fbeb39a 100644 --- a/indexer/services/ender/src/scripts/handlers/dydx_update_perpetual_v2_handler.sql +++ b/indexer/services/ender/src/scripts/handlers/dydx_update_perpetual_v2_handler.sql @@ -27,7 +27,7 @@ BEGIN WHEN event_data ? 'defaultFunding8hrPpm' THEN dydx_trim_scale( power(10, PPM_EXPONENT) / FUNDING_RATE_FROM_PROTOCOL_IN_HOURS * - (event_data->'defaultFunding8hrPpm')::numeric); + (event_data->'defaultFunding8hrPpm')::numeric) ELSE 0.0 END; UPDATE perpetual_markets