Skip to content
This repository has been archived by the owner on Aug 17, 2021. It is now read-only.

Extend the use-tailwind-ppx script with new parameters #86

Open
dylanirlbeck opened this issue May 16, 2020 · 2 comments
Open

Extend the use-tailwind-ppx script with new parameters #86

dylanirlbeck opened this issue May 16, 2020 · 2 comments
Labels
enhancement An internal enhancement that isn't user-facing good first issue help wanted

Comments

@dylanirlbeck
Copy link
Owner

To make the script more useful, I think it'd be helpful to have the script take in the following parameters:

  • --file <path/to/file>: takes in a single Reason file - check the extension (we need to have this one)
  • --write: tells the script to actually write the new contents, in-place (this parameter is up for discussion). If --writeis not supplied, print the new contents to the console.
@dylanirlbeck dylanirlbeck added enhancement An internal enhancement that isn't user-facing help wanted labels May 16, 2020
@bdunn313
Copy link
Contributor

@dylanirlbeck I'm happy to take a crack at this one, as long as you don't mind my turnaround time being a week+ (work is busy lately).

To clarify the usage of --write - if this new parameter is present, it would behave as the script behaves now, correct? In addition, the default behavior of the script would be to output changes to stdout instead of writing in-place. Let me know if I've characterized the ask properly.

@dylanirlbeck
Copy link
Owner Author

dylanirlbeck commented Jun 10, 2020

Hi @bdunn313! You’re exactly right — default is stdout, including —write actually writes to the file. No worries on turnaround, take your time and let me know if you have any questions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An internal enhancement that isn't user-facing good first issue help wanted
Projects
None yet
Development

No branches or pull requests

2 participants