feat(rust): Add Lightstep Adapter, generate Rust types based on otel protobufs #87
Conversation
wikiwong
commented
Aug 10, 2023
wikiwong
commented
- Add Lightstep Adapter
- Generate types based on protobuf definitions
- Remove old otel formatter and replace with protobuf based formatter
rust/src/adapter/datadog.rs
Outdated
| @@ -15,7 +15,7 @@ use url::Url; | |||
|
|
|||
| use crate::{Event, Log, Metric, TraceEvent}; | |||
|
|
|||
| use super::{ | |||
| pub use super::{ | |||
There was a problem hiding this comment.
| pub use super::{ | |
| use super::datadog_formatter::{DatadogFormatter, Span, Trace}; | |
| pub use super::{ | |
| Adapter, AdapterHandle, AdapterMetadata, | |
| }; |
There was a problem hiding this comment.
(not 100% sure about that particular suggestion -- only did on github so worth checking 😆)
rust/src/adapter/honeycomb.rs
Outdated
| otel_formatter::{Attribute, Value}, | ||
| AdapterMetadata, | ||
| otel_formatter::{opentelemetry, Attribute, OtelFormatter, Value}, |
There was a problem hiding this comment.
Same suggestion as the Datadog public interface above; let's limit what we make public to only what we know the end-user needs.
This one probably should export the Attribute and Value in addition to the Adapter and related types, but not the formatter things.
rust/src/adapter/honeycomb.rs
Outdated
| let mut span = OtelFormatter::new_span( | ||
| trace_id, | ||
| parent_id, | ||
| "allocation".to_string(), | ||
| a.ts, | ||
| a.ts, | ||
| ); | ||
| OtelFormatter::add_attribute_i64_to_span( | ||
| &mut span, | ||
| "amount".to_string(), | ||
| a.amount.into(), | ||
| ); |
There was a problem hiding this comment.
This is my bad (fixed in Go and JS, but i guess i forgot in Rust), but we need to fix this in all the adapters.. memory allocation events should pop the last function from the stack and add the allocation as an attribute to that, using the number of pages (the a.amount) as the value. Then, push that function back onto the stack and carry on
rust/src/adapter/lightstep.rs
Outdated
| Event::Alloc(a) => { | ||
| let mut span = OtelFormatter::new_span( | ||
| trace_id, | ||
| parent_id, | ||
| "allocation".to_string(), | ||
| a.ts, | ||
| a.ts, | ||
| ); | ||
| OtelFormatter::add_attribute_i64_to_span( | ||
| &mut span, | ||
| "amount".to_string(), | ||
| a.amount.into(), | ||
| ); | ||
| spans.push(span); | ||
| } | ||
| _ => {} | ||
| } | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
same comment re: attaching the allocation as an attribute to the previous function in the spans.
| status: None, | ||
| events: vec![], | ||
| links: vec![], | ||
| trace_state: "".into(), |
There was a problem hiding this comment.
no need to update in the PR, but for future cases like this you can pass ..Default::default() as the last field in a struct literal as long as the Default trait is implemented. This will fill in the rest of the fields not explicitly included with their default values (like you've done manually).
