From 1886e18d788b9b2745b1989a472084985578a147 Mon Sep 17 00:00:00 2001 From: Daniel T <30197399+danwt@users.noreply.github.com> Date: Tue, 14 May 2024 12:57:37 +0100 Subject: [PATCH] fix(local pub sub): use error for subscription cancelled (instead of info) (#853) --- block/synctarget.go | 2 +- settlement/dymension/dymension.go | 2 +- utils/event/funcs.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block/synctarget.go b/block/synctarget.go index 471a0334a..e76bb1ac4 100644 --- a/block/synctarget.go +++ b/block/synctarget.go @@ -38,7 +38,7 @@ func (m *Manager) SyncTargetLoop(ctx context.Context) { m.UpdateSyncParams(eventData.EndHeight) m.SyncTargetDiode.Set(diodes.GenericDataType(&eventData.EndHeight)) case <-subscription.Cancelled(): - m.logger.Info("syncTargetLoop subscription canceled") + m.logger.Error("syncTargetLoop subscription canceled") return } } diff --git a/settlement/dymension/dymension.go b/settlement/dymension/dymension.go index e46790888..d3dbaee9f 100644 --- a/settlement/dymension/dymension.go +++ b/settlement/dymension/dymension.go @@ -255,7 +255,7 @@ func (d *HubClient) PostBatch(batch *types.Batch, daClient da.Client, daResult * return d.ctx.Err() case <-subscription.Cancelled(): - return fmt.Errorf("subscription cancelled: %w", err) + return fmt.Errorf("subscription cancelled") case <-subscription.Out(): d.logger.Debug("Batch accepted", "startHeight", batch.StartHeight, "endHeight", batch.EndHeight) diff --git a/utils/event/funcs.go b/utils/event/funcs.go index 85a8be224..0bfe9c965 100644 --- a/utils/event/funcs.go +++ b/utils/event/funcs.go @@ -34,7 +34,7 @@ func MustSubscribe( case event := <-subscription.Out(): callback(event) case <-subscription.Cancelled(): - logger.Info(clientID + " subscription canceled") + logger.Error("subscription cancelled", "clientID", clientID) return } }