From 3cee2475a56cc2831f3a49c854903928b53adf96 Mon Sep 17 00:00:00 2001 From: Daniel T <30197399+danwt@users.noreply.github.com> Date: Tue, 14 May 2024 13:21:53 +0100 Subject: [PATCH] fix(docs): make submit loop comment more accurate re batch size (#852) --- block/submit.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/block/submit.go b/block/submit.go index 2ae8b0978..5110a8dff 100644 --- a/block/submit.go +++ b/block/submit.go @@ -46,11 +46,9 @@ func (m *Manager) SubmitLoop(ctx context.Context) { } /* - Note: since we dont explicitly coordinate changes to the accumulated size with actual batch creation - we don't have a guarantee that the accumulated size is the same as the actual batch size that will be made. - See https://github.com/dymensionxyz/dymint/issues/828 - Until that is fixed, it's technically possibly to undercount, by having a some blocks be produced in between - setting the counter to 0, and actually producing the batch. + Note: since we dont explicitly coordinate changes to the accumulated size with actual batch creation + we don't have a guarantee that the accumulated size is the same as the actual batch size that will be made. + But the batch creation step will also check the size is OK, so it's not a problem. */ m.AccumulatedBatchSize.Store(0)