Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node_address in dymint.toml is confusing #493

Closed
omritoptix opened this issue Sep 28, 2023 · 0 comments · Fixed by #868
Closed

node_address in dymint.toml is confusing #493

omritoptix opened this issue Sep 28, 2023 · 0 comments · Fixed by #868
Assignees
@mtsitrin
Labels
good first issue Good for newcomers T:config T:refactor

Comments

@omritoptix
Copy link
Contributor

the node_address in dymint.toml refers to the settlement node address, however it isn't prefixed with a settlement or with a comment suggesting it.

it caused rollapp users accidently to put their the sequencer address.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtsitrin mtsitrin

Labels
good first issue Good for newcomers T:config T:refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(config): better naming for settlement config dymensionxyz/dymint
2 participants
@omritoptix @mtsitrin