You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead, we should just always add blocks to the cache, and then apply from the cache
We should remove the path to apply directly
It will be less code and more maintainable
The text was updated successfully, but these errors were encountered:
I think it would be good if whenever we get a block, we send it to channel
and there is a goroutine to listen on this channel and apply to cache, and he will apply the blocks when the cache has the next one needed
this way we get rid of all mutex related to cache access and simplify the flow
ie. there should only be one applyBlock call in the code
We have unnecessary branching in our code because we, currently
dymint/block/manager.go
Lines 242 to 253 in 7c19785
dymint/block/retriever.go
Lines 88 to 100 in df192a9
Instead, we should just always add blocks to the cache, and then apply from the cache
We should remove the path to apply directly
It will be less code and more maintainable
The text was updated successfully, but these errors were encountered: