Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DA namespace encoded as utf string and not as hexa string #730

Closed
omritoptix opened this issue Apr 28, 2024 · 1 comment
Closed

DA namespace encoded as utf string and not as hexa string #730

omritoptix opened this issue Apr 28, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@omritoptix
Copy link
Contributor

it caused hexa repr like 2e to be intereperted as our seperator (i.e .) which caused the logic of len parts to fail which is based on out seperator.
The right way would be to encode as hexa string and decode as extra string.

The logic that failed:

if len(pathParts) == 7 { (we got 8 instead)

@omritoptix omritoptix added the bug Something isn't working label Apr 28, 2024
@srene
Copy link
Contributor

srene commented Apr 29, 2024

fixed in this pr #731

@srene srene closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants