Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settlement): filter by pending status in batch event #845

Merged
merged 2 commits into from
May 12, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented May 10, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


Close #844

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene self-assigned this May 10, 2024
@srene srene requested a review from a team as a code owner May 10, 2024 14:11
@mtsitrin mtsitrin merged commit 841056d into main May 12, 2024
4 checks passed
@mtsitrin mtsitrin deleted the srene/844-new-batch-event-pending branch May 12, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter subscription to settlement events by status pending
2 participants