Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow itest_service to not be started at "boot" #38

Open
darkrift opened this issue Dec 10, 2024 · 3 comments
Open

Allow itest_service to not be started at "boot" #38

darkrift opened this issue Dec 10, 2024 · 3 comments

Comments

@darkrift
Copy link
Contributor

darkrift commented Dec 10, 2024

The use case is for testing cron jobs. The ask is to not start a specific itest_service to allow the service_test to exclusively start it through svcctl.

This allows to properly setup the environment from the service_test itself before the "job" starts and then assert on the execution.

@dzbarsky
Copy link
Owner

Yep this has been on my wishlist but not implemented yet. One thing to think through is the behavior when a non-deferred service depends on a deferred one (and how deps work here in general, I think we may have punted on that for the Start rpc). You interested in giving it a shot?

@darkrift
Copy link
Contributor Author

darkrift commented Dec 11, 2024

Non-deferred service depending on deferred services doesn't make sense.

We could probably even validate that in Starlark and fail at analysis time.

As for deferred services depending on other deferred services, this could be validated when calling the /start endpoint and validate that all dependencies are currently running.

Wdyt ?

@dzbarsky
Copy link
Owner

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants