-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few more cleanup issues #13
Comments
Also, really need to think through the settings code on startup. For example, the base app is a thin skin and does not make any server calls or collect any data. So it theoretically should not need to set any settings. HOWEVER, if I remove all the startup code (https://github.com/e-mission/e-mission-base/blob/master/www/js/app.js#L51), then when I do try to switch clients, I get an error
Basically, the auth code is also triggered when we open the URL, and in the auth code startup, we assume that the settings should already be set. I think that we had some assumptions about when settings should be configured using javascript, but we need to work through the design choices and come up with a unified workflow |
Few more cleanup issues for #9
client
field in the profile when the user switches to a different client (at least by URL)The text was updated successfully, but these errors were encountered: