From 0f2f5de312cd5480e83005d6caa3daf3accad2d8 Mon Sep 17 00:00:00 2001
From: "K. Shankari" <shankari@eecs.berkeley.edu>
Date: Wed, 27 Apr 2022 00:01:43 -0700
Subject: [PATCH] Add additional logging + one more overlay hide

I would normally not push this, but we missed one overlay hide
when generating an infinite scroll event.

+ add additional timing information so we can see the cause of the delay on my
personal phone and where we may want to move the overlay code
---
 www/js/diary/infinite_scroll_list.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/www/js/diary/infinite_scroll_list.js b/www/js/diary/infinite_scroll_list.js
index 52365b567..469802306 100644
--- a/www/js/diary/infinite_scroll_list.js
+++ b/www/js/diary/infinite_scroll_list.js
@@ -85,16 +85,19 @@ angular.module('emission.main.diary.infscrolllist',['ui-leaflet',
   }
 
   $scope.readDataFromServer = function() {
+    Logger.log("Called readDataFromServer");
     $scope.infScrollControl.fromBottom = getFromBottom()
     $scope.infScrollControl.callback = adjustScrollAfterDownload;
     console.log("calling readDataFromServer with "+
         JSON.stringify($scope.infScrollControl));
     const currEnd = $scope.infScrollControl.currentEnd;
     if (!angular.isDefined(currEnd)) {
-        console.log("trying to read data too early, early return");
+        Logger.log("trying to read data too early, early return");
+        $ionicLoading.hide();
         $scope.$broadcast('scroll.infiniteScrollComplete')
         return;
     }
+    Logger.log("Turning on the ionic loading overlay in setupInfScroll");
     $ionicLoading.show({
         template: $translate.instant('service.reading-server')
     });
@@ -149,6 +152,7 @@ angular.module('emission.main.diary.infscrolllist',['ui-leaflet',
     $scope.infScrollControl.reachedEnd = false;
     $scope.data.allTrips = [];
     $scope.data.displayTrips = [];
+    Logger.log("Turning on the ionic loading overlay in setupInfScroll");
     $ionicLoading.show({
         template: $translate.instant('service.reading-server')
     });