Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name change request for "Pre-analysis Assisted Rate Control" in the GUI, based on new feature names #21

Open
cs9kc opened this issue Apr 1, 2022 · 0 comments

Comments

@cs9kc
Copy link

cs9kc commented Apr 1, 2022

In the GUI, you list "Pre-analysis Assisted Rate Control". This is a deprecated name for the feature.

The feature is now referred to as "PREENCODE". This item is located on line 163 of VideoEncoderVCE.h in the AMF package, with the following help-text: "enables pre-encode assisted rate control".
https://github.com/GPUOpen-LibrariesAndSDKs/AMF/blob/master/amf/public/include/components/VideoEncoderVCE.h

The entry for PREENCODE is correct in encoder_avc.cpp
https://github.com/e00E/obs-amf/blob/master/source/encoder_avc.cpp

In the GUI, this should be changed to "Pre-Encode Assisted Rate Control"

HEVC has the same options in VideoEncoderHEVC.h on lines 167 for PREENCODE and 149 for PRE_ANALYSIS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant