Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds "added by" and "added at" columns to the table, changes to API header #490

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Adds "added by" and "added at" columns to the table, changes to API header #490

merged 5 commits into from
Dec 5, 2024

Conversation

mishushakov
Copy link
Member

  • Adds "added by" and "added at" columns to the table
  • Changes to API /teams/:id/users headers

Blocked by https://github.com/e2b-dev/billing/pull/25

@mishushakov mishushakov requested a review from jakubno as a code owner December 3, 2024 22:04
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 96441e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jakubno
jakubno requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@jakubno jakubno left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong PR

@mishushakov
Copy link
Member Author

Your screenshot shows templates view, this is for team users view

@jakubno
Copy link
Member

jakubno commented Dec 5, 2024

Sorry, my bad, I went back to wrong tab

jakubno
jakubno approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@jakubno jakubno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jakubno jakubno merged commit 786fcd8 into main Dec 5, 2024
3 checks passed
@jakubno jakubno deleted the teams-improved-users branch December 5, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0div 0div 0div left review comments

@jakubno jakubno jakubno approved these changes

@mlejva mlejva Awaiting requested review from mlejva

@ValentaTomas ValentaTomas Awaiting requested review from ValentaTomas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mishushakov @jakubno @0div