Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid runtime allocations #2

Open
bonnee opened this issue May 12, 2021 · 0 comments
Open

Avoid runtime allocations #2

bonnee opened this issue May 12, 2021 · 0 comments

Comments

@bonnee
Copy link
Contributor

bonnee commented May 12, 2021

The error subsystem relies on llist to store errors ordered by priority. This is problematic because llist uses dynamic allocations at runtime. With this method an insert operation is O(n) and a removal is O(1) (with the help of an array that stores the index of allocations).

To replace llist it would be adequate to find a solution that is at least as efficient as llist is now. min-heap seems to be a good candidate if paired with list_ref.

While runtime memory allocation is not ideal, it doesn't affect my sleep too much, so this issue is not really an urgent one.

@notfilippo notfilippo transferred this issue from eagletrt/fenice-bms-hv Nov 7, 2021
bonnee pushed a commit that referenced this issue Nov 11, 2021
can: implementing bms network
federico-carbone added a commit that referenced this issue Nov 9, 2022
can: implementing bms network
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant