Move sitecustomize.py into site-packages #3514
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Micket
force-pushed
the
sitecustomize
branch
from
adcf2f0
to
8c30f6b
Compare
Flamefire
suggested changes
Nov 25, 2024
| if self.cfg.get('ebpythonprefixes'): | ||
| txt += self.module_generator.prepend_paths(PYTHONPATH, self.pythonpath) | ||
| new_dir = os.path.join('lib', 'python' + self.pyshortver, 'site-packages') | ||
| old_dir = os.path.join(log_path(), 'python') |
There was a problem hiding this comment.
log_path isn't actually the correct path, see #3400
Maybe we can either use easybuild directly (if I remember that path correctly) or at least add a comment why log_path is abused here
| txt += self.module_generator.prepend_paths(PYTHONPATH, self.pythonpath) | ||
| new_dir = os.path.join('lib', 'python' + self.pyshortver, 'site-packages') | ||
| old_dir = os.path.join(log_path(), 'python') | ||
| if not os.path.exists(os.path.join(self.installdir, new_dir, 'sitecustomize.py')): |
There was a problem hiding this comment.
Shall we maybe use a "constant" for this path similar to self.pythonpath to avoid repeating it in 2 locations that are quite a bit apart? I'd also check if the script exists in old_dir (or at least that folder) before adding the old path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3493