{data}[intel/2015b] CRF++ 0.58 + homepage/source_urls fixes for existing CRF++ easyconfigs (REVIEW) #2080
Conversation
…ing CRF++ easyconfigs
|
Test report by @boegel |
|
Test report by @boegel |
| @@ -12,8 +12,9 @@ description = """CRF++ is a simple, customizable, and open source implementation | |||
| toolchain = {'name': 'goalf', 'version': '1.1.0-no-OFED'} | |||
| toolchainopts = {'optarch': True, 'pic': True, 'opt': True} | |||
|
|
|||
| # manual download from https://taku910.github.io/crfpp/#download (via Google Drive) | |||
There was a problem hiding this comment.
Why not use https://github.com/taku910/crfpp/tree/master ?
There was a problem hiding this comment.
because it's not clear whether that corresponds to which version
the checksum included here makes very sure we're getting the right source tarball
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4838/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Looks ok, but it's much more preferable for upstream to have the correct tags. I've put in an issue here: taku910/crfpp#19. If they tag the build, please update these scripts to use the github tarballs directly. |
|
@ehiggs: yup, will do |
|
Thanks for the review @ehiggs! |
{data}[intel/2015b] CRF++ 0.58 + homepage/source_urls fixes for existing CRF++ easyconfigs (REVIEW)
No description provided.