Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove/rename build directory before running sanity check #4588

Open
boegel opened this issue Jul 31, 2024 · 1 comment
Open

remove/rename build directory before running sanity check #4588

boegel opened this issue Jul 31, 2024 · 1 comment
Labels
Milestone

Comments

@boegel
Copy link
Member

boegel commented Jul 31, 2024

We recently ran into a broken installation when using RPATH, for which the sanity check passed.

The problem was that the binaries were finding libraries in the build directory, which is removed when completing the installation, see vscentrum/vsc-software-stack#364 (comment) for more details.

This indicates that we should remove/rename the build directory before we run the sanity check, since there may be "false positives" for sanity check commands when the build directory is still in place...

@boegel boegel added change EasyBuild-5.0 EasyBuild 5.0 EasyBuild-5.0-blocker Blocker for EasyBuild 5.0 labels Jul 31, 2024
@boegel boegel added this to the 5.0 milestone Jul 31, 2024
@Flamefire
Copy link
Contributor

I'd prefer renaming for the sanity-check and renaming it back using a context manager such that --disable-cleanup-build allows proper inspection after a (failed) build

@boegel boegel moved this to Breaking changes in EasyBuild v5.0 Aug 26, 2024
@boegel boegel added enhancement and removed EasyBuild-5.0-blocker Blocker for EasyBuild 5.0 labels Nov 6, 2024
@boegel boegel moved this from Breaking changes to Nice-to-have in EasyBuild v5.0 Nov 6, 2024
@boegel boegel removed the change label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Nice-to-have
Development

No branches or pull requests

2 participants