Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete module for extensions #4647

Open
Flamefire opened this issue Sep 20, 2024 · 1 comment · May be fixed by #4652
Open

Incomplete module for extensions #4647

Flamefire opened this issue Sep 20, 2024 · 1 comment · May be fixed by #4652

Comments

@Flamefire
Copy link
Contributor

I just noticed that the SciPy-bundle module generated by --module-only is missing some paths.

Those are supposed to be added by the numpy extension. However the current mechanism is flawed:

The problems with this are:

  1. For --module-only this is not run
  2. For --skip it might not be run
  3. For --parallel-extension it is not used either:

From our "official" easyblocks only numpy uses that mechanism.

So we need a new method for extensions that returns the module-extra when used as an extension. The current make_module_extra cannot be used for that.

I'd propose make_module_extra_extension but we already have make_module_extra_extensions which would be confusing.

@boegel boegel added this to the release after 4.9.4 milestone Sep 21, 2024
Flamefire added a commit to Flamefire/easybuild-framework that referenced this issue Sep 23, 2024
Introduce `make_extension_module_extra` which gets called during module
file creation for every extension similar to `make_module_extra`.
This ensures it will also be called for parallel extension or --module-only builds.

Fixes easybuilders#4647
@Flamefire Flamefire linked a pull request Sep 23, 2024 that will close this issue
Flamefire added a commit to Flamefire/easybuild-framework that referenced this issue Sep 23, 2024
Introduce `make_extension_module_extra` which gets called during module
file creation for every extension similar to `make_module_extra`.
This ensures it will also be called for parallel extension or --module-only builds.

Fixes easybuilders#4647
Flamefire added a commit to Flamefire/easybuild-framework that referenced this issue Sep 23, 2024
Introduce `make_extension_module_extra` which gets called during module
file creation for every extension similar to `make_module_extra`.
This ensures it will also be called for parallel extension or --module-only builds.

Fixes easybuilders#4647
@Flamefire
Copy link
Contributor Author

Flamefire commented Sep 23, 2024

@boegel I'd also consider this a blocker for 5.x especially as it is pretty much impossible to fix this in a fully backwards compatible manner, see the PR: #4652

Flamefire added a commit to Flamefire/easybuild-framework that referenced this issue Sep 23, 2024
Introduce `make_extension_module_extra` which gets called during module
file creation for every extension similar to `make_module_extra`.
This ensures it will also be called for parallel extension or --module-only builds.

Fixes easybuilders#4647
Flamefire added a commit to Flamefire/easybuild-framework that referenced this issue Sep 23, 2024
Introduce `make_extension_module_extra` which gets called during module
file creation for every extension similar to `make_module_extra`.
This ensures it will also be called for parallel extension or --module-only builds.

Fixes easybuilders#4647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants