-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incomplete module for extensions #4647
Labels
Milestone
Comments
Flamefire
added a commit
to Flamefire/easybuild-framework
that referenced
this issue
Sep 23, 2024
Introduce `make_extension_module_extra` which gets called during module file creation for every extension similar to `make_module_extra`. This ensures it will also be called for parallel extension or --module-only builds. Fixes easybuilders#4647
Flamefire
added a commit
to Flamefire/easybuild-framework
that referenced
this issue
Sep 23, 2024
Introduce `make_extension_module_extra` which gets called during module file creation for every extension similar to `make_module_extra`. This ensures it will also be called for parallel extension or --module-only builds. Fixes easybuilders#4647
Flamefire
added a commit
to Flamefire/easybuild-framework
that referenced
this issue
Sep 23, 2024
Introduce `make_extension_module_extra` which gets called during module file creation for every extension similar to `make_module_extra`. This ensures it will also be called for parallel extension or --module-only builds. Fixes easybuilders#4647
Flamefire
added a commit
to Flamefire/easybuild-framework
that referenced
this issue
Sep 23, 2024
Introduce `make_extension_module_extra` which gets called during module file creation for every extension similar to `make_module_extra`. This ensures it will also be called for parallel extension or --module-only builds. Fixes easybuilders#4647
Flamefire
added a commit
to Flamefire/easybuild-framework
that referenced
this issue
Sep 23, 2024
Introduce `make_extension_module_extra` which gets called during module file creation for every extension similar to `make_module_extra`. This ensures it will also be called for parallel extension or --module-only builds. Fixes easybuilders#4647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just noticed that the
SciPy-bundle
module generated by--module-only
is missing some paths.Those are supposed to be added by the
numpy
extension. However the current mechanism is flawed:ext.run()
is collected in a variable:easybuild-framework/easybuild/framework/easyblock.py
Lines 1950 to 1952 in bf0af10
easybuild-framework/easybuild/framework/easyblock.py
Line 1466 in bf0af10
The problems with this are:
--module-only
this is not run--skip
it might not be run--parallel-extension
it is not used either:easybuild-framework/easybuild/framework/easyblock.py
Line 2014 in bf0af10
From our "official" easyblocks only
numpy
uses that mechanism.So we need a new method for extensions that returns the module-extra when used as an extension. The current
make_module_extra
cannot be used for that.I'd propose
make_module_extra_extension
but we already havemake_module_extra_extensions
which would be confusing.The text was updated successfully, but these errors were encountered: