-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry Check on BOP #129
Comments
this sounds cool :D can you please try and add this in the new Resistor repo? :) would be nice with an example |
@Shackmeister |
This means my freecad is too old. (For some reason the last build for fedora was 48 days ago.) |
@poeschlr |
a working models generator with Union and BOP check is ready here: |
I tested it with your example file and my freecad version indeed discovered that the resistor is invalid. |
Hi @Shackmeister and all developers,
I've just updated the 'cq_cad_tools.py' adding two new functions:
and a source file to run these functions (I included all the functions in the file so to be able to run it easily)
checkBOP-example.py
I attached here also a wrong STEP model, not correctly union-ed and with wrong geometries to make some tests.
resistor-wrong-BOP.zip
uploaded also on the repo...
It is suggested to generate/export a STEP model, then close the file generator and import the STEP file;
then run the checkUnion function to see if the STEP file is correcty union-ed in a single part and run the checkBOP function to see if there are errors on the STEP shape.
This is going to be a quite robust check on the generated files... still in some case I found BOP check is not perfect, but it is for sure much better than the previous state.
Requirements:
The text was updated successfully, but these errors were encountered: