Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email templating: URL construction for links unpurposeful, leads to information disclosure in some cases #472

Open
jane-heller-bkg opened this issue Oct 14, 2024 · 0 comments

Comments

@jane-heller-bkg
Copy link

jane-heller-bkg commented Oct 14, 2024

The URL for links that are presented to the user, eg. to activate accounts is based on the internal variable mail.smtp.host, which the application uses to contact its mailserver to deliver the email. That does not make sense.

Some of the URLs are generated in sources/Re3gistry2/src/main/java/eu/europa/ec/re3gistry2/web/controller/RegistryManagerUsersAdd.java:246 (as of commit 41ce0d21d146c0af344ec873977dbc02aeb07aea) and following line.
URL needs to be created following a fixed scheme, eg. derived out of a single variable in the configuration. Software seems to handle URL generation arbitrarily at the moment, see also e.g. #438, #367

This is also a security issue because it leads to an information disclosure about internal contact addresses of mailservers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant