Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer instruction in CONTRIBUTING #325

Closed
shenchenruwo opened this issue Nov 13, 2024 · 1 comment · Fixed by #327
Closed

Clearer instruction in CONTRIBUTING #325

shenchenruwo opened this issue Nov 13, 2024 · 1 comment · Fixed by #327

Comments

@shenchenruwo
Copy link

After the structure shift, it would be better to add a short instruction for running the test.
We must run the checks in the sdk folder, and this is now not described in the document.
It is maybe better also to clarify/document this.

Related content:
"Running all checks:

mypy basyx test
pycodestyle --max-line-length 120 basyx test
python -m unittest"

@shenchenruwo
Copy link
Author

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant