Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rimraf dependency from prod to dev #95

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

marcdumais-work
Copy link
Contributor

rimraf is used as a development dependency but was pulled as a production dependency. This had the side-effect of making its own production dependencies mandatory for other projects using it.

rimraf is used as a development dependency but was pulled as a
production dependency. This had the side-effect of making its
own production dependencies mandatory for other projects using
it.

Signed-off-by: Marc Dumais <[email protected]>
Copy link
Collaborator

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@marcdumais-work marcdumais-work merged commit 15e47a8 into master Feb 13, 2024
4 checks passed
@marcdumais-work marcdumais-work deleted the rimraf-dev-dep branch February 13, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants