From 0fc7e93f386568c246741c27b5045427165b95e1 Mon Sep 17 00:00:00 2001 From: Marc Dumais Date: Thu, 1 Feb 2024 12:00:26 -0500 Subject: [PATCH 1/2] [CI] Have publish CI job trigger on tag creation When we previously created the v0.2.0 release using the RELEASE file, the corresponding GitHub release and git tag were created. However the publish job was not triggered. Testing on my fork, I concluded that the workflow needs to trigger on "create" tag, not on "push". A slight side-effect of triggering the ci-cd workflow on "create" events is that it will now run also on branch creation. So it may run a bit more often than before. I think this is preferable for now, vs having complex "if:" conditions on each job in the workflow. This commit fixes this. Signed-off-by: Marc Dumais --- .github/workflows/ci-cd.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index a4f3f7d3..aab5d544 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -3,10 +3,10 @@ name: CI/CD on: push: branches: [ master ] - tags: - - 'v*' pull_request: branches: [ master ] + # branch or tag created + create: jobs: From f974ded238aad13327df5003beffe82faafd8cfc Mon Sep 17 00:00:00 2001 From: Marc Dumais Date: Thu, 1 Feb 2024 12:10:08 -0500 Subject: [PATCH 2/2] Trigger a new release: v0.2.1 This commit steps the tag in file RELEASE to v0.2.1 to trigger a new release, which this time will hopefully trigger the publish job and successfully publish the extension to open-vsx. Afterwards, I plan to delete the (failed) v0.2.0 release, and copy its generated release notes to the new release Signed-off-by: Marc Dumais --- RELEASE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASE b/RELEASE index d79cc087..00507270 100644 --- a/RELEASE +++ b/RELEASE @@ -1,4 +1,4 @@ -tag: v0.2.0 +tag: v0.2.1 commitInclude: parentOfMergeCommit: true