Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint dependency to >= 8.43.0 #193

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

marcdumais-work
Copy link
Contributor

@marcdumais-work marcdumais-work commented Jan 29, 2024

Earlier versions contain content that's licensed under an unapproved license. I adjusted the version we request in a few places.

An older version was still being pulled from one of our dependencies, rewire. Upon searching the sources, I could not find where this dependency was being used and so I removed it.

Also updated some eslint-related packages that were quite old.

@marcdumais-work marcdumais-work marked this pull request as draft January 29, 2024 22:06
@marcdumais-work marcdumais-work force-pushed the update-eslint branch 2 times, most recently from 3942d01 to 9c6e2a8 Compare February 13, 2024 16:25
Also updated some related packages that were quite old.

Earlier versions of eslint have content that's licensed under an
unapproved license. I adjusted the version we request in a few places.

An older version was still being pulled from one of our dependencies,
"rewire". Upon searching the sources, I could not find where this
dependency was being used and so I removed it.

Signed-off-by: Marc Dumais <[email protected]>
@marcdumais-work marcdumais-work marked this pull request as ready for review February 13, 2024 17:52
Copy link
Collaborator

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for update!

@marcdumais-work marcdumais-work merged commit 2443855 into master Feb 13, 2024
4 of 5 checks passed
@marcdumais-work marcdumais-work deleted the update-eslint branch February 13, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants