[CI] Use 'list' Playwright reporter, use longer timeout #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcdumais-work
force-pushed
the
playwright-ci-reporter
branch
from
81f4a67 to
2d4b0d7
Compare
When running the tests locally, the current 'html' reporter is fine. But I've been confused with it in CI logs where there was a failure, presumably a silent retry and finally a report of the tests passing. I think in CI we would have more clarity with an alternate reporter. Let's try 'list'. If it does not work well we can fall-back on the simple 'dot'. Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
playwright-ci-reporter
branch
from
2d4b0d7 to
806c79c
Compare
|
We got lucky: we got the case I was trying to improve in the latest CI run (a testcase failure followed by a report of overall success): With the new reporter, we can see just above a report of the test running, aiding in interpreting what has happened exactly: |
|
I think maybe the (default?) timeout of 5000ms might be a little short |
marcdumais-work
changed the title
Timeouts with the default, rather short 5000ms timeout can be observed semi-regularly. Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
playwright-ci-reporter
branch
from
38bed86 to
cbc61fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the tests locally, the current 'html' reporter is fine. But I've been confused with it in CI logs where there was a failure, presumably a silent retry and finally a report of the tests passing.
I think in CI we would have more clarity with an alternate reporter. Let's try 'list'. If it does not work well we can fall-back on the simple 'dot'.