Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic issue and pull-request templates #290

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

marcdumais-work
Copy link
Contributor

What it does

This PR adds an issue and PR template in this repo, heavily inspired from those of the Eclipse Theia project (look at the raw files to see the parts that are comments):
Theia Issue templace (composed of a few files)
Theia PR template

How to test

The new issue template will not be visible here until this PR is merged. To see what this will look-like, look at the theia-trace-extension - create new issue, where we already added the same templates.

For the PR template, I'm using it right here (manually copied and filled-in). Much of the template is in the form of comments - to see the details review the raw files.

Follow-ups

N/A

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the instructions in this template

Copy link
Collaborator

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing to update. Thanks for the contribution.

### Additional Information

- Operating System:
- Theia Version:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be VsCode version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected

Copy link
Collaborator

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution.

@marcdumais-work
Copy link
Contributor Author

Thanks for the review!

@marcdumais-work marcdumais-work merged commit 9a3f2d1 into master Dec 2, 2024
6 checks passed
@marcdumais-work marcdumais-work deleted the github-templates branch December 2, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants