Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check .clangd configuration file syntax #247

Closed
ghentschke opened this issue Feb 6, 2024 · 3 comments · Fixed by #249
Closed

Check .clangd configuration file syntax #247

ghentschke opened this issue Feb 6, 2024 · 3 comments · Fixed by #249
Milestone
1.1.0

Comments

@ghentschke
Copy link
Contributor

Because of #245, the user has to be informed, that the yaml syntax is invalid. It's assumed that the user has no yaml editor in his Eclipse IDE and if so, the .clangd file would not be recognized as yaml file since it has no file ending.
@ghentschke ghentschke mentioned this issue Feb 6, 2024
Merged
@jonahgraham
Copy link
Member

Can we create an error marker for the problematic clangd file?

@ghentschke
Copy link
Contributor Author

Can we create an error marker for the problematic clangd file?

That's exactly what I'am currently working on :-)

@jonahgraham
Copy link
Member

Can we create an error marker for the problematic clangd file?

That's exactly what I'am currently working on :-)

:-) Brilliant!

ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Feb 6, 2024
@ghentschke
[eclipse-cdt#247] Add .clangd configuration file syntax checker
64f8d69 
- Inform the user via markers in the .clangd file when the syntax cannot
be parsed, because this leads to problems in the
ClangdConfigurationFileManager.
@ghentschke ghentschke mentioned this issue Feb 6, 2024
Merged
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Feb 7, 2024
@ghentschke
[eclipse-cdt#247] Add .clangd configuration file syntax checker
c714fe7 
- Fetch info from MarkedYAMLException to create a marker for the .clangd
file.

fixes eclipse-cdt#247
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Feb 7, 2024
@ghentschke
[eclipse-cdt#247] Add .clangd configuration file syntax checker
8792280 
- add unit tests
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Feb 7, 2024
@ghentschke
[eclipse-cdt#247] Add .clangd configuration file syntax checker
b64d55a 
- fix review comments
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Feb 8, 2024
@ghentschke
[eclipse-cdt#247] Add .clangd configuration file syntax checker
4493b67 
- fix review comments
- use IResource.DEPTH_ZERO in deleteMarkers, since the config file has
no members.
ghentschke added a commit that referenced this issue Feb 9, 2024
@ghentschke
[#247] Add .clangd configuration file syntax checker (#249)
d4bca9e 
[#247] Add .clangd configuration file syntax checker

- Inform the user via markers in the .clangd file when the syntax cannot
be parsed, because this leads to problems in the
ClangdConfigurationFileManager.
- Works for UTF-8 characters in text file.

fixes #247
@ghentschke ghentschke added this to the 1.1.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

[#247] Add .clangd configuration file syntax checker ghentschke/eclipse-cdt-lsp
2 participants
@jonahgraham @ghentschke