-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD ARG to decide if starting Derby #5
Comments
This should be done in a different way - the database should be rather started in embedded mode (in the same process), or in a separate container. Starting a separate database process in the same container is an antipattern - Docker is designed to have a single process running. With #22, it will be possible to do this already with a file mounted to Better is to use one of the below solutions:
I think supporting running Derby DB in a separate container is not worth it, because Derby DB should not be used in production. Therefore I would just support Embedded mode. To support Embedded mode, we just need to run a single asadmin command in Dockerfile to change the URL of the datasource to use embedded Derby. The database would be started lazily, only if the default datasource is used. |
Embedded mode is okay for developers. We can start it by default or add an ARG to the docker file to determine whether to start it. |
I think using |
Add arg to dockerfile to allow developers decide if start database at the same time.
The text was updated successfully, but these errors were encountered: