Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIComponent#PropertyKeys#binding still not removed in 5.0? #5514

Closed
tandraschko opened this issue Oct 14, 2024 · 3 comments
Closed

UIComponent#PropertyKeys#binding still not removed in 5.0? #5514

tandraschko opened this issue Oct 14, 2024 · 3 comments

Comments

@tandraschko
Copy link
Contributor

as discussed here: jakartaee/faces#1969
@tandraschko tandraschko mentioned this issue Oct 14, 2024
Closed
@BalusC
Copy link
Contributor

BalusC commented Oct 19, 2024 •
edited
Loading

Removing it causes UIComponent#getValueExpression() to not anymore work because these are saved in state on that key.

Should we rename PropertyKeys.bindings to PropertyKeys.valueExpressions?

Btw this issue belongs in Faces project because associated code is since 5.0 not anymore in Mojarra project.

@tandraschko
Copy link
Contributor Author

+1 for PropertyKeys.valueExpressions

@BalusC
Copy link
Contributor

BalusC commented Jan 21, 2025

Ok, continue in jakartaee/faces#1725

@BalusC BalusC closed this as completed Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BalusC @tandraschko