Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update header layout #329

Closed
geziefer opened this issue Aug 26, 2024 · 4 comments
Closed

Update header layout #329

geziefer opened this issue Aug 26, 2024 · 4 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists UI User Interface

Comments

@geziefer
Copy link
Contributor

In the new version 2.0.6, the menu is in the image.
image

@m-reza-rahman
Copy link
Contributor

m-reza-rahman commented Aug 26, 2024

I have no idea what to make of this or what action to take. Is this a bug? An enhancement request? What is the actual change requested or issue to be fixed? Is this something existing or the result of a recent change?

Also, are you aware the Eclipse Foundation determines the layout of the header and footer? Indeed, both are in the process of being fetched dynamically soon: #293.

@m-reza-rahman m-reza-rahman changed the title Menu layout wrong in starter Update header layout Aug 26, 2024
@m-reza-rahman m-reza-rahman changed the title Update header layout Change header layout Aug 26, 2024
@m-reza-rahman m-reza-rahman changed the title Change header layout Update header layout Aug 26, 2024
@geziefer
Copy link
Contributor Author

Well, the menu items are practically unreadable, that is definitely an issue.
We could either have the menu above the banner, as it is on the main page jakarta.ee, or we could have a different CSS for it to make it readable on top of the banner.

@geziefer
Copy link
Contributor Author

In case #293 addresses this and makes the menu readable again, this ticket could be closed.

@m-reza-rahman
Copy link
Contributor

m-reza-rahman commented Aug 27, 2024

I am closing this as essentially a duplicate/out of scope to keep the issues clutter free. As I mentioned, this is not up to us. This is what the header layout was when we initially pulled it. Let's see what pulling the current headers does. If you have further feedback after that, you should provide it to the Eclipse Foundation, probably via @shabnammayel. We need to conform to whatever the Eclipse Foundation layout is.

@m-reza-rahman m-reza-rahman added bug Something isn't working duplicate This issue or pull request already exists UI User Interface labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists UI User Interface
Projects
None yet
Development

No branches or pull requests

2 participants