Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password hints not removed when changing password without creating new hints #687

Open
ivgag opened this issue Oct 9, 2024 · 0 comments

Comments

@ivgag
Copy link

ivgag commented Oct 9, 2024

When using org.eclipse.equinox.internal.security.ui.storage.ChangePasswordWizard to change a password, the old hints remain if the user opts not to create new password hints. This allows the new password to be recovered using the previous hints, creating a security vulnerability.

Steps to Reproduce:

  1. Initiate password change using ChangePasswordWizard.
  2. Enter current and new passwords.
  3. Choose to skip creating new password hints.
  4. Attempt to recover the new password using old hints.

Expected Behavior:
Old password hints should be removed when a user opts not to create new hints, as this prevents the new password from being recovered with previous hints.

Actual Behavior:
Old password hints remain, allowing the new password to be recovered.

Suggested Fix:
Update org.eclipse.equinox.internal.security.ui.storage.UICallbackProvider#setupPasswordRecovery to remove existing password hints when the user opts not to create new ones during a password change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant