Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use precise coordinates in org.eclipse.gmf.runtime.diagram.ui.tools.DragEditPartsTrackerEx.snapPoint(ChangeBoundsRequest) #63

Closed
lredor opened this issue Apr 25, 2024 · 0 comments · Fixed by #64
Milestone

Comments

@lredor
Copy link
Contributor

lredor commented Apr 25, 2024

In Sirius #359, a bug has been discovered in GMF. In the method org.eclipse.gmf.runtime.diagram.ui.tools.DragEditPartsTrackerEx.snapPoint(ChangeBoundsRequest) the x and y coordinates are used. But if the moveDelta is a PrecisionPoint, preciseX() and preciseY() should be used instead. Indeed, according to the zoom level, preciseX or preciseY can be something like 0.5 and must no be considered as 0.

lredor added a commit to lredor/gmf-runtime that referenced this issue Apr 25, 2024
lredor added a commit to eclipse-sirius/sirius-desktop that referenced this issue Apr 25, 2024
This commit removes the code duplicated from GMF as the bug is now
directly fixed in GMF (through issue
eclipse-gmf-runtime/gmf-runtime#63).

Bug: #378
@pcdavid pcdavid added this to the 1.16.4 milestone Apr 30, 2024
lredor added a commit to eclipse-sirius/sirius-desktop that referenced this issue Jun 27, 2024
This commit removes the code duplicated from GMF as the bug is now
directly fixed in GMF (through issue
eclipse-gmf-runtime/gmf-runtime#63).

Bug: #378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants