Hot code replace error box "Details button" bug

[SougandhS]

I tried the error cases for Hot code replace functionality. On every fail the pop up shows additional "Details >>" button, On clicking the button it shows the same message as provided in the parent box ("Reason" line)

Please advice whether we should keep this button or not ?

[SougandhS]

@jukzi @iloveeclipse any suggestions ?

[jukzi]

maybe in other situations it displays more information? i don't know.

[SougandhS]

I think its same

[SougandhS]

For obsolete methods error box we dont have that details button

[SougandhS]

While HCR fails the detailMessage generated is used for both reason and details button

and StackTrace is also not available for the exceptions

[iloveeclipse]

I could only guess that original IBM JVM (J9) may provide more info, but I haven't looked at the code if there is additional handling of the "details" content and if that is coming from another source as the visible part of the message.

If that is feed with the same data, then the "details" part is obviously wasting space, if not, it should be kept.

[SougandhS]

I could only guess that original IBM JVM (J9) may provide more info, but I haven't looked at the code if there is additional handling of the "details" content and if that is coming from another source as the visible part of the message.

If that is feed with the same data, then the "details" part is obviously wasting space, if not, it should be kept.

Went through it again and found for some selected JDWP error codes throw UnsupportedOperationException with a fixed string message, and this same message is used in "details" section

[SougandhS]

Checked with other few scenarios having other than unsupported exception, Only showing exception classes

---

---

[SougandhS]

Hi @iloveeclipse, @jukzi shall we include the exception class details in "Details" for unsupported [ADD,DELETE etc] ones similar to the other exceptions ?
we can then avoid same text showing in both.

[SougandhS]

Hi @iloveeclipse, @jukzi shall we include the exception class details in "Details" for unsupported [ADD,DELETE etc] ones similar to the other exceptions ? we can then avoid same text showing in both.

How about including corresponding error code + unsupported exception class name ?
As error codes are common for all JVMs

[jukzi]

I am not interested in the topic of hot code replace failures. But if you show after/before screenshots of changes that might make sense then i might take a look.

[SougandhS]

I am not interested in the topic of hot code replace failures. But if you show after/before screenshots of changes that might make sense then i might take a look.

before it used to show this
[Details section shows same as shown in reason]

my proposal -

[jukzi]

looks good.

[SougandhS]

looks good.

Thanks