You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It means that monitor must be created after the collect of DelegateCommandHandlerDescriptor:
Collection<DelegateCommandHandlerDescriptor> candidates = handlers.stream().filter(desc -> desc.getAllCommands().contains(params.getCommand())).collect(Collectors.toSet()); //no cancellation here but it's super fast so it's ok.
What about if some candidates have a progress capability and other have not progress capability?
The text was updated successfully, but these errors were encountered:
JDT LS provides a client
progress support
which is used only internally.It should be very fantastic if we could benefit of this progress support with
custom delegate command handler
.It will avoid for external JDL LS extension like STS to implement their own progress support. @martinlippert what do you think about this idea?
Please note that LSP progress support is planned :
Manage of progress support for delegate command handler is to create an instance of
ProgressReporter
instead ofCancellableProgressMonitor
like today.Here the current code of JDTLanguageServer:
A very simple fix is to replace
computeAsync
withcomputeAsyncWithClientProgress
But it will throw some progression information although command handler doesn't want to manage progress.
A clean solution should check if command to execute has a progress capability or not.
To do that we could manage this capability in plugin.xml with
command/@progress
:It means that monitor must be created after the collect of DelegateCommandHandlerDescriptor:
What about if some candidates have a progress capability and other have not progress capability?
The text was updated successfully, but these errors were encountered: