We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mockito.mock
JKube Kit
Related to #2316
VertxGeneratorIsApplicableTest seems to be using mock here :
jkube/jkube-kit/jkube-kit-vertx/src/test/java/org/eclipse/jkube/vertx/generator/VertxGeneratorIsApplicableTest.java
Line 41 in dad4cc6
This can easily be refactored to use real object using lombok builders:
project = JavaProject.builder().build(); context = GeneratorContext.builder() .project(project) .build();
Similarly these when( statements can also be replaced with builder calls like this:
when(
Lines 59 to 60 in dad4cc6
context = context.toBuilder() .project(project.toBuilder().plugins(pluginList).dependencies(dependencyList).build()) .build();
Usage of org.mockito.Mockito.mock and org.mockito.Mockito.when is removed from VertxGeneratorIsApplicableTest
org.mockito.Mockito.mock
org.mockito.Mockito.when
Usages of Mockito.mock and Mockito.when are removed from VertxGeneratorIsApplicableTest
Mockito.when
The text was updated successfully, but these errors were encountered:
Hi @rohanKanojia, Can you assign this to me ?
Sorry, something went wrong.
Hi @manusa, can you assign this to me?
Adarsha186
Successfully merging a pull request may close this issue.
Component
JKube Kit
Task description
Component
JKube Kit
Task description
Related to #2316
VertxGeneratorIsApplicableTest seems to be using mock here :
jkube/jkube-kit/jkube-kit-vertx/src/test/java/org/eclipse/jkube/vertx/generator/VertxGeneratorIsApplicableTest.java
Line 41 in dad4cc6
This can easily be refactored to use real object using lombok builders:
Similarly these
when(
statements can also be replaced with builder calls like this:jkube/jkube-kit/jkube-kit-vertx/src/test/java/org/eclipse/jkube/vertx/generator/VertxGeneratorIsApplicableTest.java
Lines 59 to 60 in dad4cc6
Usage of
org.mockito.Mockito.mock
andorg.mockito.Mockito.when
is removed from VertxGeneratorIsApplicableTestExpected Behavior
Usages of
Mockito.mock
andMockito.when
are removed from VertxGeneratorIsApplicableTestAcceptance Criteria
The text was updated successfully, but these errors were encountered: