Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Real coverage percentage is not shown in README.md #94

Closed
daniel-milchev opened this issue Jan 18, 2024 · 1 comment · Fixed by #95
Closed

Real coverage percentage is not shown in README.md #94

daniel-milchev opened this issue Jan 18, 2024 · 1 comment · Fixed by #95
Assignees
@daniel-milchev
Labels
task Single unit of work
Milestone
M5

Comments

@daniel-milchev
Copy link
Contributor

Not all of the unit tests have been run by generate-coverage-report.yaml. An additional tag must be added to the coverage-command.
@daniel-milchev daniel-milchev added the task Single unit of work label Jan 18, 2024
@daniel-milchev daniel-milchev added this to the M4 milestone Jan 18, 2024
@daniel-milchev daniel-milchev self-assigned this Jan 18, 2024
@daniel-milchev daniel-milchev moved this to In Progress (max 10) in Eclipse Kanto Jan 18, 2024
daniel-milchev added a commit to bosch-io/file-upload that referenced this issue Jan 19, 2024
@daniel-milchev
[eclipse-kanto#94] Added the missing tag.
32cd376
@daniel-milchev daniel-milchev mentioned this issue Jan 19, 2024
Merged
@daniel-milchev daniel-milchev moved this from In Progress (max 10) to Ready for Review (max 3) in Eclipse Kanto Jan 19, 2024
@dimitar-dimitrow dimitar-dimitrow modified the milestones: M4, M5 Jan 19, 2024
@dimitar-dimitrow dimitar-dimitrow changed the title Real coverage percentage is not shown in README.md Real coverage percentage is not shown in README.md - File Upload Jan 19, 2024
@dimitar-dimitrow dimitar-dimitrow mentioned this issue Jan 19, 2024
Closed
@dimitar-dimitrow
Copy link
Contributor

dimitar-dimitrow commented Jan 19, 2024 •
edited
Loading

When the unit tag is set, some *_test_util.go files are included as well in the coverage report. This leads to overall drop in the total coverage percent, which is shown with the coverage badge.

@dimitar-dimitrow dimitar-dimitrow changed the title Real coverage percentage is not shown in README.md - File Upload Real coverage percentage is not shown in README.md Jan 19, 2024
@dimitar-dimitrow dimitar-dimitrow moved this from Ready for Review (max 3) to In Progress (max 10) in Eclipse Kanto Jan 19, 2024
@k-gostev k-gostev moved this from In Progress (max 10) to Ready for Review (max 3) in Eclipse Kanto Jan 23, 2024
@dimitar-dimitrow dimitar-dimitrow linked a pull request Jan 23, 2024 that will close this issue
Added the missing tag #95
Merged
dimitar-dimitrow pushed a commit that referenced this issue Jan 23, 2024
@daniel-milchev
Added the missing tag. (#95)
0560739 
[#94] Real coverage percentage is not shown in README.md

Signed-off-by: Daniel Milchev [email protected]
@github-project-automation github-project-automation bot moved this from Ready for Review (max 3) to Done in Eclipse Kanto Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-milchev daniel-milchev

Labels
task Single unit of work
Projects
Eclipse Kanto
Status: Done
Milestone
M5
Development

Successfully merging a pull request may close this issue.

Added the missing tag bosch-io/file-upload
2 participants
@dimitar-dimitrow @daniel-milchev