"Go to definition" doesn't work for token has union of rules

[jindong-zhannng]

Hi there,

I'm implementing a TS-like language including type alias:

type MyType = something
              // ^ can be a built-in type, inline type definition or a type reference

To achieve it, here is partial of my grammar:

TypeAliasDeclaration:
  'type' name=ID '=' type=TypeExpr;

TypeExpr:
  PrimitiveTypeExpr | CompositeTypeExpr | TypeRefExpr;

TypeRefExpr:
  ref=[TypeDeclaration];

TypeDeclaration:
  TypeAliasDeclaration | TypeParameterDeclaration;

TypeParameterDeclaration:
  name=ID;

I expect that TypeExpr can be a cross-reference to TypeAliasDeclaration or TypeParameterDeclaration. It works on parsing documents and references are correct in ASTs.

But in VSCode extension, there is no "Go to definition" action (and others) on TypeExpr tokens. How could I fix it?

[msujew]

Hey @jindong-zhannng,

are you sure that the language server is running and that VS Code associates the language to the language client? It looks to me like like it doesn't. There are quite a few missing context menu entries that should be added if the language server is running.

Note that I've tried reproducing this in the playground and it seems to work. So it's more likely an issue in the VS Code/language server configuration.

[jindong-zhannng]

You're right. Shame on me I forgot to add language to documentSelector🤦. Everything works well now after I added. Thanks a lot!