Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop jarsigning #1862

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Stop jarsigning #1862

merged 1 commit into from
Oct 4, 2024

Conversation

akurtakov
Copy link
Contributor

PGP sign is enough, simrel no longer requires jarsigning and build becomes faster and more stable without the network roadtrips caused by eclipse-jarsigner.

Copy link

github-actions bot commented Oct 4, 2024

Test Results

  321 files    321 suites   49m 15s ⏱️
  678 tests   658 ✅ 18 💤 1 ❌ 1 🔥
2 034 runs  1 978 ✅ 54 💤 1 ❌ 1 🔥

For more details on these failures and errors, see this check.

Results for commit 9f6fe43.

♻️ This comment has been updated with latest results.

@akurtakov akurtakov self-assigned this Oct 4, 2024
PGP sign is enough, simrel no longer requires jarsigning and build
becomes faster and more stable without the network roadtrips caused by
eclipse-jarsigner.
@HannesWell
Copy link
Contributor

@laeubi are you fine with this?
I think it's worth a try.

@laeubi
Copy link
Member

laeubi commented Oct 4, 2024

I have no concerns.

@akurtakov
Copy link
Contributor Author

Merging in this case.

@akurtakov akurtakov merged commit 6b94b54 into eclipse-m2e:master Oct 4, 2024
7 of 8 checks passed
@HannesWell
Copy link
Contributor

Since this change, when updating to the latest snapshots of m2e I always get the message that the m2e artifacts are unsigned.
I don't know why this is the case, but it's bad and unless we can fix this quickly I contemplate to revert this for the release I plan to do this evening.

@akurtakov
Copy link
Contributor Author

I have just installed everything from the snapshots repo and didn't get warnings and looking at https://www.eclipse.org/downloads/download.php?file=/technology/m2e/snapshots/latest/artifacts.xml.xz I see pgp.signatures so please share exactly which bundles are unsigned for you.

@HannesWell
Copy link
Contributor

After doing another update I didn't get a corresponding message.
Looks like false alarm. Sorry for the disturbance!

@HannesWell HannesWell added this to the 2.7.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants