Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expensive operations running on initialization of tabs #1232

Open
1 task
fedejeanne opened this issue Apr 15, 2024 · 2 comments
Open
1 task

Expensive operations running on initialization of tabs #1232

fedejeanne opened this issue Apr 15, 2024 · 2 comments

Comments

@fedejeanne
Copy link
Contributor

fedejeanne commented Apr 15, 2024

Some tabs still rely on the method initializeFrom to perform the heavy lifting.

This sometimes leads to unnecessary (sometimes even expensive) calculations, since not all tabs are ever going to be activated (i.e. selected).

These are the ones I've identified so far:

@fedejeanne
Copy link
Contributor Author

BTW these are some samplings showing the initialization times of TestTab and PluginsTab (see vi-eclipse/Eclipse-PDE#2)

Image

Snapshot (same as eclipse-jdt/eclipse.jdt.core#1214): open-run-configurations-dialog.zip

@fedejeanne
Copy link
Contributor Author

Improving the TestTab will not be possible (or at least now worth the effort) because the expensive operation is calculating the methods that can run in a test configuration. This is necessary to calculate if the configuration is valid (isValid) and this is necessary when initializing the tab because the whole configuration is only valid if each one of their tabs is valid.

This wasn't the case with the PluginsTab because the validation in that tab was a NO-OP.

I'm scratching the task from this issue (in the description)

fedejeanne added a commit to fedejeanne/eclipse.pde that referenced this issue Apr 17, 2024
- Inline value and delete outdated JavaDoc

Contributes to eclipse-pde#1232

Co-authored-by: Hannes Wellmann <[email protected]>
fedejeanne added a commit to fedejeanne/eclipse.pde that referenced this issue Apr 17, 2024
- Inline value and delete outdated JavaDoc

Contributes to eclipse-pde#1232

Co-authored-by: Hannes Wellmann <[email protected]>
fedejeanne added a commit to fedejeanne/eclipse.pde that referenced this issue Apr 17, 2024
- Inline value and delete outdated JavaDoc

Contributes to eclipse-pde#1232

Co-authored-by: Hannes Wellmann <[email protected]>
fedejeanne added a commit to fedejeanne/eclipse.pde that referenced this issue Apr 17, 2024
- Inline value and delete outdated JavaDoc

Contributes to eclipse-pde#1232

Co-authored-by: Hannes Wellmann <[email protected]>
fedejeanne added a commit to fedejeanne/eclipse.pde that referenced this issue Apr 19, 2024
- Inline value and delete some outdated JavaDoc
- Skip calls to AbstractpluginBlock::performApply before the block is
even created to avoid NPEs

Contributes to eclipse-pde#1232

Co-authored-by: Hannes Wellmann <[email protected]>
HannesWell added a commit to fedejeanne/eclipse.pde that referenced this issue Apr 20, 2024
- Inline value and delete some outdated JavaDoc
- Skip calls to AbstractpluginBlock::performApply before the block is
even created to avoid NPEs

Contributes to eclipse-pde#1232

Co-authored-by: Hannes Wellmann <[email protected]>
fedejeanne added a commit to fedejeanne/eclipse.pde that referenced this issue Apr 22, 2024
- Inline value and delete some outdated JavaDoc
- Skip calls to AbstractpluginBlock::performApply before the block is
even created to avoid NPEs

Contributes to eclipse-pde#1232

Co-authored-by: Hannes Wellmann <[email protected]>
fedejeanne added a commit to fedejeanne/eclipse.pde that referenced this issue Apr 22, 2024
- Inline value and delete some outdated JavaDoc
- Skip calls to AbstractpluginBlock::performApply before the block is
even created to avoid NPEs

Contributes to eclipse-pde#1232

Co-authored-by: Hannes Wellmann <[email protected]>
HannesWell added a commit that referenced this issue Apr 22, 2024
- Inline value and delete some outdated JavaDoc
- Skip calls to AbstractpluginBlock::performApply before the block is
even created to avoid NPEs

Contributes to #1232

Co-authored-by: Hannes Wellmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant