Unable to run plug-in tests after opening Plugins tab #1250
Comments
|
@fedejeanne : please check. |
iloveeclipse
changed the title
|
I also reproduced the issue, changing default start level to 1 and setting auto-start to false allows to get things working. |
PluginsTab" This change reverts main change from commit 98a5865 changes because it caused a severe regression. See eclipse-pde#1233 Fixes eclipse-pde#1250
|
@fedejeanne : I plan to merge #1251 for the next IBuild (will be 4.32 M2) tomorrow, assuming there will be no fix available before 23:00 CET today. |
Thank you for the heads up and for looking into it! I was just looking into it but I couldn't reproduce the error. I'll perform the setup tasks and try again later (I need to leave the office in 2 minutes). |
|
Quick update: I'm on Version: 2024-06 (4.32) And I can't reproduce the error. The |
|
Maybe this is something Linux specific, I don't know, I haven't debugged this. You can try with any launch config that is created automatically. Compare the file content after creation and after opening the launch configurations dialog. You actually should see it immediately by the wrong defaults set in the dialog. |
PluginsTab" This change reverts main change from commit 98a5865 changes because it caused a severe regression. See eclipse-pde#1233 Fixes eclipse-pde#1250
|
@iloveeclipse I'll try to reproduce it and fix it on my Linux machine later today then. Thanks for the details! |
PluginsTab" This change reverts main change from commit 98a5865 changes because it caused a severe regression. See eclipse-pde#1233 Fixes eclipse-pde#1250
|
Another quick update: I was able to reproduce the error on Windows. I was blinded by the fact that the tests ran fine, but the console was showing errors and the Default start level and Default Auto-Start are definitely being set to 1 and true. I'm looking into it right now. |
If this method (or part of it) is run before the tab has been activated then the default configuration passed as parameter will be modified and incorrect values will be introduced. This commit fixes a regression introduced in 98a5865 Fixes eclipse-pde#1250
|
@iloveeclipse I proposed a fix --> #1252 I tested the same scenarios that I tested in #1233 (see its section How to test) and I additionally made sure that the default values for the configuration that reaches the Plugins tab is now overwritten. More details in the (edited) description of the PR. Hope this helps! |
|
Verified works again with I20240424-1800 |
If this method (or part of it) is run before the tab has been activated then the default configuration passed as parameter will be modified and incorrect values will be introduced. This commit fixes a regression introduced in 98a5865 Fixes eclipse-pde#1250
If this method (or part of it) is run before the tab has been activated then the default configuration passed as parameter will be modified and incorrect values will be introduced. This commit fixes a regression introduced in 98a5865 Fixes eclipse-pde#1250
If this method (or part of it) is run before the tab has been activated then the default configuration passed as parameter will be modified and incorrect values will be introduced. Remove attributes in PDE launch configurations instead of explicitly setting them to their default values The attributes in question are: - DESELECTED_WORKSPACE_BUNDLES --> [] - USE_CUSTOM_FEATURES --> false - SHOW_SELECTED_ONLY --> false - INCLUDE_OPTIONAL --> true - AUTOMATIC_ADD --> true The reason to do this is that 2 launch configurations are considered different if one of them explicitly sets an attribute to its default value (because it then has 1 more attribute) This commit fixes a regression introduced in 98a5865 Fixes eclipse-pde#1250
If this method (or part of it) is run before the tab has been activated then the default configuration passed as parameter will be modified and incorrect values will be introduced. Remove attributes in PDE launch configurations instead of explicitly setting them to their default values The attributes in question are: - DESELECTED_WORKSPACE_BUNDLES --> [] - USE_CUSTOM_FEATURES --> false - SHOW_SELECTED_ONLY --> false - INCLUDE_OPTIONAL --> true - AUTOMATIC_ADD --> true The reason to do this is that 2 launch configurations are considered different if one of them explicitly sets an attribute to its default value (because it then has 1 more attribute) This commit fixes a regression introduced in 98a5865 Fixes eclipse-pde#1250
If this method (or part of it) is run before the tab has been activated then the default configuration passed as parameter will be modified and incorrect values will be introduced. Remove attributes in PDE launch configurations instead of explicitly setting them to their default values The attributes in question are: - DESELECTED_WORKSPACE_BUNDLES --> [] - USE_CUSTOM_FEATURES --> false - SHOW_SELECTED_ONLY --> false - INCLUDE_OPTIONAL --> true - AUTOMATIC_ADD --> true The reason to do this is that 2 launch configurations are considered different if one of them explicitly sets an attribute to its default value (because it then has 1 more attribute) This commit fixes a regression introduced in 98a5865 Fixes eclipse-pde#1250
If this method (or part of it) is run before the tab has been activated then the default configuration passed as parameter will be modified and incorrect values will be introduced. Remove attributes in PDE launch configurations instead of explicitly setting them to their default values The attributes in question are: - DESELECTED_WORKSPACE_BUNDLES --> [] - USE_CUSTOM_FEATURES --> false - SHOW_SELECTED_ONLY --> false - INCLUDE_OPTIONAL --> true - AUTOMATIC_ADD --> true The reason to do this is that 2 launch configurations are considered different if one of them explicitly sets an attribute to its default value (because it then has 1 more attribute) This commit fixes a regression introduced in 98a5865 Fixes eclipse-pde#1250
If this method (or part of it) is run before the tab has been activated then the default configuration passed as parameter will be modified and incorrect values will be introduced. Remove attributes in PDE launch configurations instead of explicitly setting them to their default values The attributes in question are: - DESELECTED_WORKSPACE_BUNDLES --> [] - USE_CUSTOM_FEATURES --> false - SHOW_SELECTED_ONLY --> false - INCLUDE_OPTIONAL --> true - AUTOMATIC_ADD --> true The reason to do this is that 2 launch configurations are considered different if one of them explicitly sets an attribute to its default value (because it then has 1 more attribute) This commit fixes a regression introduced in 98a5865 Fixes eclipse-pde#1250
If this method (or part of it) is run before the tab has been activated then the default configuration passed as parameter will be modified and incorrect values will be introduced. Remove attributes in PDE launch configurations instead of explicitly setting them to their default values The attributes in question are: - DESELECTED_WORKSPACE_BUNDLES --> [] - USE_CUSTOM_FEATURES --> false - SHOW_SELECTED_ONLY --> false - INCLUDE_OPTIONAL --> true - AUTOMATIC_ADD --> true The reason to do this is that 2 launch configurations are considered different if one of them explicitly sets an attribute to its default value (because it then has 1 more attribute) This commit fixes a regression introduced in 98a5865 Fixes eclipse-pde#1250
If this method (or part of it) is run before the tab has been activated then the default configuration passed as parameter will be modified and incorrect values will be introduced. Remove attributes in PDE launch configurations instead of explicitly setting them to their default values The attributes in question are: - DESELECTED_WORKSPACE_BUNDLES --> [] - USE_CUSTOM_FEATURES --> false - SHOW_SELECTED_ONLY --> false - INCLUDE_OPTIONAL --> true - AUTOMATIC_ADD --> true The reason to do this is that 2 launch configurations are considered different if one of them explicitly sets an attribute to its default value (because it then has 1 more attribute) This commit fixes a regression introduced in 98a5865 Fixes eclipse-pde#1250
If this method (or part of it) is run before the tab has been activated then the default configuration passed as parameter will be modified and incorrect values will be introduced. Remove attributes in PDE launch configurations instead of explicitly setting them to their default values The attributes in question are: - DESELECTED_WORKSPACE_BUNDLES --> [] - USE_CUSTOM_FEATURES --> false - SHOW_SELECTED_ONLY --> false - INCLUDE_OPTIONAL --> true - AUTOMATIC_ADD --> true The reason to do this is that 2 launch configurations are considered different if one of them explicitly sets an attribute to its default value (because it then has 1 more attribute) This commit fixes a regression introduced in 98a5865 Fixes eclipse-pde#1250
I'm unable to run successfully plugins tests anymore after opening launch config dialog / Plugins tab.
If I run a test for the first time (without opening dialog) it works, but once the config is opened, it's over, it crashes with obscure errors.
I see that the launch config gets these (highly unexpected) lines added:
Steps to reproduce:
Save this file to the org.eclipse.core.tests.resources/URIUtilTest.launch file
URIUtilTest.javain the Package explorer, Debug As -> JUnit Plugin TestNote, URIUtilTest is just an example, it affects actually any plugin test
Must be regression from #1233
The text was updated successfully, but these errors were encountered: