Adding SWT + JFace when creating a plugin that "makes contribution to the UI" #1306

[cervantes-yadira]

According to the original issue, using JFace and SWT is almost necessary for plugins that contribute to the UI. Since these dependencies can be easily removed and are already dependencies of Eclipse, we decided to add them by default.

Fixes #1306

[github-actions]

Test Results

   283 files   -   2     283 suites   - 2   46m 53s ⏱️ - 4m 34s
 3 586 tests ±  0   3 509 ✅  -   1   77 💤 + 1  0 ❌ ±0 
10 784 runs   - 166  10 581 ✅  - 138  203 💤  - 28  0 ❌ ±0 

Results for commit 582b331. ± Comparison against base commit 29ff363.

This pull request skips 1 test.

org.eclipse.pde.build.internal.tests.p2.P2Tests ‑ offBug237662

♻️ This comment has been updated with latest results.

[HannesWell]

Hi @cervantes-yadira, thank you for this PR. It already looks quite good. Nice work.
I just have a comment in the code to further refine this.

If you apply the changes, please amend your commit locally and force push the amended commit to the branch of this PR so that we get a nice and clean history.

[HannesWell]

Thanks for the update, the code looks perfect now!

Unfortunately we are currently in the quiet-period before the December release and have to await the start of the next development cycle, which should start in one to two weeks, before this can be submitted.

In the meantime could you enhance the commit message by appending a reference to the fixed issue, i.e. by appending to the message by the line:
Fixes https://github.com/eclipse-pde/eclipse.pde/issues/1306

and then again force push the updated commit to this PR's branch (and you fetch from this repository and rebase on top of the current master).

@laeubi, @vogella or @opcoach, since you discussed in the fixed issue, are you fine with this change as well?

[vogella]

Change looks fine to me, thanks @cervantes-yadira

I think this solution is fine, additional checkboxes in the UI might IMHO not be necessary.

[eclipse-pde-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From aae04aabc370dd5fcf72fedf4e457d8da84338f5 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Wed, 27 Nov 2024 17:45:44 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
index 1cb90287e4..bf220bd5e8 100644
--- a/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.ui; singleton:=true
-Bundle-Version: 3.15.400.qualifier
+Bundle-Version: 3.15.500.qualifier
 Bundle-Activator: org.eclipse.pde.internal.ui.PDEPlugin
 Bundle-Vendor: %provider-name
 Bundle-Localization: plugin
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

[HannesWell]

Thanks for the update.